This repository was archived by the owner on Nov 26, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
This repository was archived by the owner on Nov 26, 2019. It is now read-only.
The favourites tab needs to be hooked to the USERDATA.dat file #45
Open
Open
The favourites tab needs to be hooked to the USERDATA.dat file#45
Description
So it will be easier to handle the favourites. It should use the same favourites list as the samp.exe browser. Looks like you already did most of the work for this, but for some reason you forgot to finish it.
Also:
ServerBrowser/client/src/main/java/com/msc/serverbrowser/data/FavouritesController.java
Lines 43 to 76 in ad937d4
| public static SampServer addServerToFavourites(final String address, final Integer port) { | |
| final SampServer server = new SampServer(address, port); | |
| try (final SampQuery query = new SampQuery(server.getAddress(), server.getPort())) | |
| { | |
| query.getBasicServerInfo().ifPresent(serverInfo -> { | |
| server.setPlayers(Integer.parseInt(serverInfo[1])); | |
| server.setMaxPlayers(Integer.parseInt(serverInfo[2])); | |
| server.setHostname(serverInfo[3]); | |
| server.setMode(serverInfo[4]); | |
| server.setLanguage(serverInfo[5]); | |
| }); | |
| query.getServersRules().ifPresent(rules -> { | |
| server.setWebsite(rules.get("weburl")); | |
| server.setVersion(rules.get("version")); | |
| }); | |
| } | |
| catch (final SocketException | UnknownHostException exception) { | |
| Logging.warn("Error updating server information.", exception); | |
| server.setHostname(UNKNOWN); | |
| server.setLanguage(UNKNOWN); | |
| server.setMode(UNKNOWN); | |
| server.setWebsite(UNKNOWN); | |
| server.setVersion(UNKNOWN); | |
| server.setLagcomp(UNKNOWN); | |
| server.setPlayers(0); | |
| server.setMaxPlayers(0); | |
| } | |
| Logging.info("Adding server to favourites: " + server); | |
| addServerToFavourites(server); | |
| return server; | |
| } |
It looks like you should just return without actually calling addServerToFavourites(server); if that exception is caught. If I'm not missing anything.