Light Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rework Cinnamon components#59

Open
Caverns4 wants to merge 2 commits intoB00merang-Project:masterfrom
Caverns4:master
Open

Rework Cinnamon components#59
Caverns4 wants to merge 2 commits intoB00merang-Project:masterfrom
Caverns4:master

Conversation

Copy link

Caverns4 commented Nov 19, 2025

Themeing now works with the new dialogue styles in Linux Mint 21 and above.

Themeing now works with the new dialogue styles in Linux Mint 21 and above.
Copy link
Member

Elbullazul commented Nov 19, 2025

Looks like you put a lot of effort into this patch; it is very appreciated.

I found a few regressions when testing your patches:

  1. the scrollbars are very thin. I would revert to the previous code for them, since they look thicker and also include the "handle" in the slider
  2. the toggles were switched from checkboxes to radioboxes. I think a checkbox better illustrates the on/off status of a toggle than a radiobutton, so I'd remove the new Switches (to be used in menus) block
  3. the panel labels for the Embedded and Royale variants now show black text, which is hard to read, and doesn't follow the original white text of both themes.

Otherwise, it looks good to me, and ready to be merged once these issues are fixed.

Copy link
Author

Caverns4 commented Nov 20, 2025 *
edited
Loading

As far as I can tell now, all the issues are fixed, only thing I couldn't figure out is that on the normal Royale theme the clock text is body. Its supposed to be black, but not have the shadow.

Copy link
Member

Elbullazul commented Nov 24, 2025

For Royale, you may look into the applet.js section (line 1998), and change all the color: white/#fff lines to color: black. To remove the bold font, edit the .panel-button class and remove the font-weight: bold line.

A few other bugs have appeared:

  • Text alignment varies if an applet is hovered or not (ex. multiline clock label). You could standardize text alignment across variants by adding text-align: center; to the .applet-box class
  • the run dialog text being white. It should be fixed by changing lines 1089-1090 to
color: black;
caret-color: black;
  • some notification text is white on light yellow, so unreadable. You can test this yourself by sending a test notification with notify-send "hello-world" "some body"
  • I don't know if it's intended, but icon spacing in the right panel has been reduced in all variants, except Zune and Royale Dark. If it's intentional, could you apply the changes to them as well? If not, revert padding changes to the other variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants