-
Notifications
You must be signed in to change notification settings - Fork 349
Fixed local file partitioning file not found issue #976#981
Merged
mwylde merged 3 commits intoArroyoSystems:masterfrom Jan 13, 2026
Merged
Fixed local file partitioning file not found issue #976#981mwylde merged 3 commits intoArroyoSystems:masterfrom
mwylde merged 3 commits intoArroyoSystems:masterfrom
Conversation
Contributor
Added code to create parent directories when partitioning is used. I found that the code to automatically do this seems to have been removed when the iceberg partitioning was added (b0c83ea). I have based my code on the previous code. Please let me know if I need to change the PR in any way.
I was able to reproduce #976 and verify the fix using the following query with the nexmark data source.
CREATE TABLE sink (
window_start TIMESTAMP,
total DOUBLE,
bid_count BIGINT,
name TEXT
) WITH (
connector = 'filesystem',
type = 'sink',
path = 'file:////tmp/',
format = 'parquet',
'partitioning.time_pattern' = 'year=%Y/month=%m/day=%d/hour=%H/minute=%M'
);
INSERT INTO sink
SELECT
window.start as window_start,
total,
bid_count,
name
FROM (
SELECT
TUMBLE(INTERVAL '1 minute') as window,
person.name as name,
SUM(CAST(bid.price AS DOUBLE)) as total,
COUNT(*) as bid_count
FROM nexmark
GROUP BY
TUMBLE(INTERVAL '1 minute'),
person.name
);
window_start TIMESTAMP,
total DOUBLE,
bid_count BIGINT,
name TEXT
) WITH (
connector = 'filesystem',
type = 'sink',
path = 'file:////tmp/',
format = 'parquet',
'partitioning.time_pattern' = 'year=%Y/month=%m/day=%d/hour=%H/minute=%M'
);
INSERT INTO sink
SELECT
window.start as window_start,
total,
bid_count,
name
FROM (
SELECT
TUMBLE(INTERVAL '1 minute') as window,
person.name as name,
SUM(CAST(bid.price AS DOUBLE)) as total,
COUNT(*) as bid_count
FROM nexmark
GROUP BY
TUMBLE(INTERVAL '1 minute'),
person.name
);
=
and others
added 3 commits
December 21, 2025 19:09
mwylde
approved these changes
Jan 13, 2026
Member
mwylde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the slow review and thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.