-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
Contributor
I've been doing this by hand (editing CMakeLists.txt) for years, but I think we need a proper way to do this: disable backends at will, easily. For various reasons (LLVM linking conflicts, old broken installations for some dependency, buggy backend, ...) this is often required and thus needs to be facilitated.
This arguably also addresses the motivation for #51 by only attempting to find_package if a given backend is enabled.
Currently this defaults to try to enable all backends, before looking for their dependencies.
Alternatively we could:
- Fail if a dependency is not meant but the backend is enabled
- Do find_package first and remove the option if the dependencies aren't met
- Forcefully disable backends when depdencies aren't met (with
set(... FORCE))
Hugobros3
requested review from
PearCoding,
richardmembarth and
stlemme
and removed request for
PearCoding,
richardmembarth and
stlemme
July 23, 2024 09:31
PearCoding
reviewed
Jul 23, 2024
| target_link_libraries(runtime_pal PRIVATE runtime_base pal::pal) | ||
| list(APPEND RUNTIME_PLATFORMS runtime_pal) | ||
| option(AnyDSL_Runtime_ENABLE_PAL "Support for running kernels through AMD's PAL interface" ON) | ||
| if(AnyDSL_Runtime_ENABLE_PAL) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indentation ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.