Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fixed hasAdditionalStacksPlugin check if using modules in plugins sec...#214

Open
sampsasaarela wants to merge 1 commit into99x:v1from
sampsasaarela:fixed-has-additional-stacks-plugins
Open

Fixed hasAdditionalStacksPlugin check if using modules in plugins sec...#214
sampsasaarela wants to merge 1 commit into99x:v1from
sampsasaarela:fixed-has-additional-stacks-plugins

Conversation

Copy link

sampsasaarela commented Mar 24, 2019

Fixes _.get(...).includes is not a function error if serverless.yml looks like this:

plugins:
localPath: './plugins'
modules:
- my-custom-plugin
- serverless-domain-manager
- serverless-dynamodb-local
- serverless-offline

Copy link

designfrontier commented Apr 29, 2019

This is breaking me as well... it appears that this.service.plugins is not an array in the latest version of serverless. Which breaks the check

Copy link

vkartaviy commented May 7, 2019

I have fixed this by using pluginManager, see #222

AshanFernando approved these changes May 18, 2019
Copy link
Collaborator

AshanFernando left a comment *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sampsasaarela for the PR. There is another PR #222 for the same purpose sent later on. Will you be able to check whether there is anything we could get from it? I'm approving this, if there are any changes, please incorporate. Waiting for another review before merging.

vkartaviy mentioned this pull request May 19, 2019
Copy link
Author

sampsasaarela commented May 20, 2019

Thanks @sampsasaarela for the PR. There is another PR #222 for the same purpose sent later on. Will you be able to check whether there is anything we could get from it? I'm approving this, if there are any changes, please incorporate. Waiting for another review before merging.

I think both will do the job, but my version is not dependent parsePluginsObject, the only dependency is lodash as before and should be fully backward compatible.
vkartaviy reacted with thumbs up emoji

Copy link

cyberwombat commented Sep 5, 2019

Can this be revisited? Still unable to use enhanced plugin setup. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AshanFernando AshanFernando approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants