-
-
Notifications
You must be signed in to change notification settings - Fork 8k
refactor: remove hooks ssr param support#8491
Merged
patak-cat merged 2 commits intovitejs:mainfrom Jun 8, 2022
Merged
Conversation
Member
Description
#5253 changed ssr positional param in a property in a object. But still leaved handling for params for backwards compatibility.
Since Vite 3.0+ is only supported for plugin-*, now those can be dropped.
Additional context
What is the purpose of this pull request?
- Bug fix
- New Feature
- Documentation update
- Other
Before submitting the PR, please make sure you do the following
- Read the Contributing Guidelines.
- Read the Pull Request Guidelines and follow the Commit Convention.
- Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
- Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g.
fixes #123). - Ideally, include relevant tests that fail without this PR but pass with it.
bluwy
reviewed
Jun 8, 2022
Co-authored-by: Bjorn Lu
bluwy
approved these changes
Jun 8, 2022
patak-cat
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.