-
-
Notifications
You must be signed in to change notification settings - Fork 236
Conversation
Contributor
Description
Currently client-only error shows up as rsc:virtual-client-package:
[rsc:virtual-client-package] 'client-only' cannot be imported in server build (importer: '/home/hiroshi/code/others/vite-plugin-react/packages/plugin -rsc/examples/starter/src/root.tsx', environment: rsc)
We can hard-code server-only/client-only here to skip this step, so the error gets surfaced as:
[rsc:validate-imports] 'client-only' cannot be imported in server build (importer: '/home/hiroshi/code/others/vite-plugin-react/packages/plugin -rsc/examples/starter/src/root.tsx', environment: rsc)
This isn't fool proof though since other plugins might use this.resolve too. Eventually we should look into to surfacing errors later stage so we have a knowledge of module graph. Tracked in #863.
hi-ogawa
changed the title
fix(rsc): improve client-only error message
fix(rsc): improve server-only and client-only error message
Sep 16, 2025
hi-ogawa
changed the title
fix(rsc): improve server-only and client-only error message
fix(rsc): tweak server-only and client-only error message
Sep 16, 2025
hi-ogawa
changed the title
fix(rsc): tweak server-only and client-only error message
fix(rsc): show plugin name in server-only and client-only error message
Sep 16, 2025
hi-ogawa
changed the title
fix(rsc): show plugin name in server-only and client-only error message
fix(rsc): fix plugin name in client-only error message
Sep 16, 2025
hi-ogawa
changed the title
fix(rsc): fix plugin name in client-only error message
fix(rsc): fix plugin name in Sep 16, 2025
client-only error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.