-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix "global is not defined"#1704
Merged
jimmywarting merged 1 commit intonode-fetch:2.xfrom Jan 30, 2023
Merged
Conversation
Purpose
I think this was missed in #1534
Changes
Replace global -> globalObject
Additional information
I get a global is not defined error otherwise. (octokit is still using this instead of isomorphic-fetch/cross-fetch)
LinusU
approved these changes
Jan 19, 2023
Member
LinusU
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collaborator
|
I think we should remove All in all: "use strict";
const { fetch, Headers, Request, Response } = globalThis; module.exports = exports = fetch; // Needed for TypeScript and Webpack. if (fetch) { exports.default = fetch; } exports.Headers = Headers; exports.Request = Request; exports.Response = Response; |
NewEraCracker
approved these changes
Jan 30, 2023
Member
|
@jimmywarting what do you think about releasing this PR as is, and then someone can open a new PR for further changes? |
Collaborator
|
sure |
jimmywarting
approved these changes
Jan 30, 2023
|
This PR is included in version 2.6.9 The release is available on: Your semantic-release bot |
Brynor
approved these changes
Feb 20, 2023
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced Sep 23, 2024
This was referenced Sep 25, 2024
This was referenced Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.