-
Notifications
You must be signed in to change notification settings - Fork 194
-
|
I think it will take time for us to release a 2.0.0, which only supports Java 17+. Should we deliver features in 1.2.x and then forward-port to 2.0.0? |
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 3 comments 10 replies
-
|
I think it's fine to have features land in I would prefer first landing them in main and then back-porting to 1.x: the risk with 'forward-porting' is that we might forget, causing a 'regression' in 2.x . This is true even when we make porting easier with tools like Mergify. Forgetting a backport is less problematic compared to forgetting a forward-port. |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
As a corollary, you could argue that if you make a PR in |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
So to start off with, I don't think it was ever the plan that development on the 1.x series of Pekko would cease just because we started working on 2.0.0 on The question here is, what process should we have regarding general features/bugs/fixes for the 1.x series. Should we baes the PR first off of 2.0.x and then backport it to 1.2.x/1.3.x etc etc or should these general PR's target 1.2.x/1.3.x as a branch and then forward port it. There are pros and cos to each, with the forward porting there is a risk that we may forget a regression (as pointed out by @raboof ) but its a lot easier to make such a PR, especially if it touches code that has been modified as a specific 2.0.0 change. Its also clearer what the intent of the PR is, if it targets a 1.x branch then its a general feature but if the PR is a 2.0.0 specific change (i.e. dropping Scala 2.12, removing deprecated methods etc etc) then it targets I personally don't mind either way, just that it should be clear which approach to use. |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
I think we should add features on main and then backport to 1.2.x, I was thinking only bugfixes can be shipped to 1.2.x. |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
I would prefer to get a 2.0.0-M1 out in maybe 2 weeks and a 2.0.0-M2 2 months after that. We can decide then if we want to aim at a 2.0.0-M3 or if we want say that we have enough done to justify a 2.0.0 full release. |
Beta Was this translation helpful? Give feedback.
All reactions
-
1
-
|
Yeah,Seems 2 months is reasonable |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
With 1.x, I think 1.2.x should be mainly for bug fixes, important dependency upgrades (as long as they are not big bumps) and doc fixes. I don't mind adding some deprecations. We've already reached a stage where 1.0.x patch releases are very unlikely unless users come along with very meaningful reasons as to why they need bug fixes and patch releases to 1.0.x instead of upgrading. I think 1.1.x will reach that stage too in a few months (if we see no major issues in 1.2.x). So I'm not worried about pushing through 1.3.x and 1.4.x releases. We don't need to stay on 1.2.x indefinitely. |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
The changes in 2.0.0 are likely to mean that we have lib maintainers who don't release Pekko 2 compatible libs. Generally, we're going to have users who don't want to spend time switching over. |
Beta Was this translation helpful? Give feedback.
All reactions
-
According to semver, for 1.2.x series (since its already released) only patch updates are allowed which is basically bug fixes. New deprecations and important dependency updates would be for 1.3.x
Agreed, in fact we already have new features in the pipeline right now that asks for 1.3.x
Definitely, which is another reason why we need to continue managing 1.x series. Its hard to predict how extreme the discrepancy of users only running on 1.x will be, but years is a good back of envelope figure. |
Beta Was this translation helpful? Give feedback.