Skip to content

Commit 8399edc

committed

Fixed optional id in todo

Signed-off-by: Omkar Phansopkar

1 parent 95c11b2 commit 8399edcCopy full SHA for 8399edc

File tree

2 files changed

+3

-2

lines changed

src/services
- models
  - todo.ts
- workbenchDB.ts

2 files changed

+3

-2

lines changed

`src/services/models/todo.ts`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ import { Sequelize, DataTypes, Model } from "sequelize";`
`18`	`18`	`import { jsonDataType } from "./databaseUtils";`
`19`	`19`
`20`	`20`	`export interface TodoAttributes {`
`21`		`- id?: number;`
	`21`	`+ id: number;`
`22`	`22`	`detection_id: string;`
`23`	`23`	`issues: Record<string, string>;`
`24`	`24`	`}`

`src/services/workbenchDB.ts`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -596,8 +596,9 @@ export class WorkbenchDB {`
`596`	`596`	`// @TODO - ToDo in scans have a field review_comments, which is ideally an issue`
`597`	`597`	`// It will be changed in the schema in future`
`598`	`598`	`const todo: TodoAttributes[] = (rawTopLevelData.todo \|\| []).map(`
`599`		`- (todo: RawTopLevelTodo) => {`
	`599`	`+ (todo: RawTopLevelTodo, idx) => {`
`600`	`600`	`return {`
	`601`	`+ id: idx + 1,`
`601`	`602`	`detection_id: todo.detection_id,`
`602`	`603`	`issues: todo.review_comments,`
`603`	`604`	`};`

0 commit comments

Comments

(0)